Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[MNT] Typing: Use Literal for set_loglevel#30302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Hi all 👋, I initially attempted to address multiple points from this issue in a single PR, but I realized that it introduced unnecessary complexity, especially for someone like me who is still learning and new to contributing at this scale. To manage things better and ensure clarity in both review and implementation, I’ve now shifted to handling one fix at a time. I’ve started with set_loglevel as it seemed like a simpler, self-contained change to begin with. This approach will also help me improve gradually and avoid making mistakes across unrelated parts. Thank you so much for your patience and guidance, it’s really encouraging for a beginner like me 🙏🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, let's take this as is. And handle the question of aligning with stdlib as a follow-up topic.
nrnavaneet commentedJul 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes@timhoffm, you’re right. I’ve implemented this by normalising the input to lowercase within set_loglevel(), so it aligns with the stdlib behaviour. You think that will work? Let me know if any further changes are required. |
Uh oh!
There was an error while loading.Please reload this page.
1f29d69
to0555206
Compare
This PR addresses part of#30257 by improving type safety and IDE support for set_loglevel.
Changes in this PR:
This improves discoverability and static type checking for valid logging levels like "info", "debug", "error", etc.
Related work not included here
MarkerType updates were implemented by@ZPyrolink in#30261
Event type literals for connect methods were contributed by@ZPyrolink in#30275