Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: Fix build with pybind11 3#30289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
As ofpybind/pybind11#5212, pybind11 now uses`numpy.typing.NDArray` instead of `numpy.ndarray`, and as ofpybind/pybind11#5580, it changed the name of theinternal wrapper that Sphinx sees.Since we already ignore `numpy.float64` missing references for the samemethod, add the new name and new class to ignores as well.
tacaswell approved these changesJul 11, 2025
30f4ece intomatplotlib:main 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 11, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 11, 2025
rcomer added a commit that referenced this pull requestJul 11, 2025
…289-on-v3.10.3-docBackport PR#30289 on branch v3.10.3-doc (DOC: Fix build with pybind11 3)
QuLogic added a commit that referenced this pull requestJul 11, 2025
…289-on-v3.10.xBackport PR#30289 on branch v3.10.x (DOC: Fix build with pybind11 3)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
As ofpybind/pybind11#5212, pybind11 now uses
numpy.typing.NDArrayinstead ofnumpy.ndarray, and as ofpybind/pybind11#5580, it changed the name of the internal wrapper that Sphinx sees.Since we already ignore
numpy.float64missing references for the same method, add the new name and new class to ignores as well.PR checklist