Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Reduce pause time in interactive timer test#30271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
c72b054
to3208831
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is fine as an incremental update since you note GTK isn't being tested here.
The interactive timers are currently not correct IMO and we need to update them to make sure the timers don't overrun their pause duration. This test is completely reworked in#29062 but that is also failing on the appveyor runs with the GTK backends, I assume because the underlying OS there is causing that timer to be even slower and not get as many triggers. Feel free to review/comment on that PR if you have suggestions there too.
ac2a909
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Since the Appveyor run is timing out, I went hunting for some low hanging fruit to speed up the tests. From the slower tests, this seemed like an obvious target as each run of the test is taking ~10 seconds. This seems to work fine.
Since gtk3cairo is disabled in this test, the comment doesn't seem relevant any more.
PR checklist