Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Reduce pause time in interactive timer test#30271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

dstansby
Copy link
Member

@dstansbydstansby commentedJul 7, 2025
edited
Loading

PR summary

Since the Appveyor run is timing out, I went hunting for some low hanging fruit to speed up the tests. From the slower tests, this seemed like an obvious target as each run of the test is taking ~10 seconds. This seems to work fine.

Since gtk3cairo is disabled in this test, the comment doesn't seem relevant any more.

PR checklist

@dstansbydstansby changed the titleReduce pause time interactive timer testReduce pause time in interactive timer testJul 7, 2025
@dstansbydstansbyforce-pushed thespeedup-interactive-timer-tests branch fromc72b054 to3208831CompareJuly 8, 2025 10:59
@dstansbydstansby marked this pull request as ready for reviewJuly 8, 2025 11:00
@QuLogicQuLogic requested a review fromgreglucasJuly 8, 2025 19:59
Copy link
Contributor

@greglucasgreglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is fine as an incremental update since you note GTK isn't being tested here.

The interactive timers are currently not correct IMO and we need to update them to make sure the timers don't overrun their pause duration. This test is completely reworked in#29062 but that is also failing on the appveyor runs with the GTK backends, I assume because the underlying OS there is causing that timer to be even slower and not get as many triggers. Feel free to review/comment on that PR if you have suggestions there too.

@jkseppanjkseppan added Maintenance CI: testingCI configuration and testing labelsJul 9, 2025
@jkseppanjkseppan added this to thev3.10.4 milestoneJul 9, 2025
@jkseppanjkseppan merged commitac2a909 intomatplotlib:mainJul 9, 2025
48 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 9, 2025
@dstansbydstansby deleted the speedup-interactive-timer-tests branchJuly 9, 2025 09:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jkseppanjkseppanjkseppan approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
CI: testingCI configuration and testingMaintenance
Projects
None yet
Milestone
v3.10.4
Development

Successfully merging this pull request may close these issues.

3 participants
@dstansby@jkseppan@greglucas

[8]ページ先頭

©2009-2025 Movatter.jp