Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Time out in _get_executable_info#30256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jkseppan
Copy link
Member

@jkseppanjkseppan commentedJul 3, 2025•
edited
Loading

Time out after 30 seconds. This is used for version queries which
should be very fast, so a 30-second delay would be unusual.

GitHub Actions test runs have been hanging trying to get the
inkscape version when using Python 3.14:

https://github.com/matplotlib/matplotlib/actions/runs/16043158943/job/45268507848#step:13:836

PR summary

PR checklist

@jkseppanjkseppanforce-pushed thetimeout-get-executable-info branch frome095401 to38a4c3bCompareJuly 3, 2025 16:59


@patch('matplotlib.subprocess.check_output')
def test_get_executable_info_timeout(mock_check_output):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You could usemonkeypatch here, though I have no preference here.

@jkseppanjkseppanforce-pushed thetimeout-get-executable-info branch 2 times, most recently from066ecd9 to50f6881CompareJuly 4, 2025 03:45
@jkseppanjkseppan added this to thev3.10.4 milestoneJul 4, 2025
mock_check_output.side_effect = subprocess.TimeoutExpired(cmd=['mock'], timeout=30)

with pytest.raises(matplotlib.ExecutableNotFoundError, match='Timed out'):
print(matplotlib._get_executable_info.__wrapped__('inkscape'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the print is a bit weird here (even though it will not actually ever run, of course -- it just statically reads weird to me)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I found it useful when trying to get the patch argument right, but of course it isn't necessary now.

Time out after 30 seconds. This is used for version queries whichshould be very fast, so a 30-second delay would be unusual.GitHub Actions test runs have been hanging trying to get theinkscape version when using Python 3.14:https://github.com/matplotlib/matplotlib/actions/runs/16043158943/job/45268507848#step:13:836
@jkseppanjkseppanforce-pushed thetimeout-get-executable-info branch from50f6881 to6a01311CompareJuly 4, 2025 07:26
@anntzeranntzer merged commitede1ebb intomatplotlib:mainJul 4, 2025
40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 4, 2025
QuLogic added a commit that referenced this pull requestJul 4, 2025
…256-on-v3.10.xBackport PR#30256 on branch v3.10.x (Time out in _get_executable_info)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.4
Development

Successfully merging this pull request may close these issues.

3 participants
@jkseppan@QuLogic@anntzer
[8]ページ先頭
©2009-2025 Movatter.jp