Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Move cibuildwheel configuration to pyproject.toml#30252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
QuLogic wants to merge1 commit intomatplotlib:mainChoose a base branch fromQuLogic:cibw-pyproject
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Here for example, Pillow 11.2 (instead of the latest 11.3) was installed because of the missing manylinux2014 wheels:https://github.com/matplotlib/matplotlib/actions/runs/16042179733/job/45265805907?pr=30252#step:4:1161 |
This allows developers to test out the build locally. With this, I wasable to fix the test command by setting `PIP_PREFER_BINARY` to avoidre-building Pillow, which accidentally dropped manylinux2014 wheels inthe latest release:python-pillow/Pillow#9057Note also that we previously set `CIBW_AFTER_BUILD`, but this doesn'tseem to be a valid setting. Thus I have dropped the `twine check`, whichonly tests the `README` rendering and so checking the sdist issufficient. Additionally, I have commented out the license check, as wecannot do multiple licenses with meson-python without PEP639 (matplotlib#28982).
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This allows developers to test out the build locally. With this, I was able to fix the test command by setting
PIP_PREFER_BINARY
to avoid re-building Pillow, which accidentally dropped manylinux2014 wheels in the latest release:python-pillow/Pillow#9057Note also that we previously set
CIBW_AFTER_BUILD
, but this doesn't seem to be a valid setting. Thus I have dropped thetwine check
, which only tests theREADME
rendering and so checking the sdist is sufficient. Additionally, I have commented out the license check, as we cannot do multiple licenses with meson-python without PEP639 (#28982).PR checklist