Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adjust logic in RcParams to allow for inheritance#30245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

cvanelteren
Copy link
Contributor

We over atUltraPlot ran into an issue where I wanted to derrive our RcClass directly from matplotlib's RcParams. However, in the source I noticed there are two places where the class hardcodes the class itself. This PR addresses this issue by making that initialization tied to the class type, opening up the potential for direct inheritance without needing to override these methods.

Copy link
Member

@timhoffmtimhoffm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One a side note: There are thoughts on fundamentally reworking the rcParams mechanism (e.g.#24585,#25617). I'm not clear whether we give any guarantees that sublcassing RcParams will continue to work then. What is your motivation to subclass RcParams?

@cvanelteren
Copy link
ContributorAuthor

We add a bunch of custom rc flags, and I am currently in the process of unifying the way we used to do things and align them with how matplotlib is doing it. That is, I prefer to subclass it rather than providing a custom class that is currently very very messy.

@jklymakjklymak merged commite22a6e8 intomatplotlib:mainJul 2, 2025
38 of 39 checks passed
@cvanelteren
Copy link
ContributorAuthor

Thanks!

Is there anything I can read up on potential changes to RcParams you are considering?

@timhoffm
Copy link
Member

Is there anything I can read up on potential changes to RcParams you are considering?

no concise summary as there’s no concrete plan yet. You can have a look at the above linked items to get some ideas.

We add a bunch of custom rc flags

So all you need is additional parameters for your library? That’s something we consider to natively support one way or the other in the future.

@cvanelteren
Copy link
ContributorAuthor

Ok thanks for letting me know, and great to hear. Will keep a close eye 👀

@cvanelterencvanelteren deleted the allow-inherritance-rc branchJuly 2, 2025 15:39
@QuLogicQuLogic changed the titleAdjust logic in RcParams to allow for inherritanceAdjust logic in RcParams to allow for inheritanceJul 2, 2025
@QuLogicQuLogic added this to thev3.11.0 milestoneJul 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

4 participants
@cvanelteren@timhoffm@QuLogic@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp