Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add explicit**options: Any foradd_subplot method#30237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jkseppan merged 1 commit intomatplotlib:mainfromGameRoMan:patch-1
Jul 4, 2025

Conversation

GameRoMan
Copy link
Contributor

@GameRoManGameRoMan commentedJul 1, 2025•
edited
Loading

Add explicit**options: Any foradd_subplot method to remove "partially unknown type" warnings from type checkers like Pyright and Pylance.

Different option would be to add individually all options that this function accepts and their types, if that's better - I'll do that

…tially unknown type" warnings from type checkers like Pyright and Pylance
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@jkseppanjkseppan added this to thev3.10.4 milestoneJul 4, 2025
@jkseppanjkseppan merged commit73d0317 intomatplotlib:mainJul 4, 2025
38 of 39 checks passed
@github-project-automationgithub-project-automationbot moved this fromNeeds review toWaiting for author inFirst Time ContributorsJul 4, 2025
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 73d0317fe73adc18b87a6e0355bb2c3f84734c2e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #30237: Add explicit `**options: Any` for `add_subplot` method'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-30237-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR#30237 on branch v3.10.x (Add explicit**options: Any foradd_subplot method)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@jkseppan
Copy link
Member

@GameRoMan Thank you for your contribution! Are you willing to do the backport to v3.10.x? The instructions are in the recent message from lumberbot-app.

@GameRoMan
Copy link
ContributorAuthor

@GameRoMan Thank you for your contribution! Are you willing to do the backport to v3.10.x? The instructions are in the recent message from lumberbot-app.

I'll see, If I'll have some time, I'll do that

GameRoMan pushed a commit to GameRoMan/matplotlib that referenced this pull requestJul 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@jkseppanjkseppanjkseppan approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
Status: Waiting for author
Milestone
v3.10.4
Development

Successfully merging this pull request may close these issues.

3 participants
@GameRoMan@jkseppan@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp