Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Check that stem input is 1D#30233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:mainfromQuLogic:stem-1d
Jul 6, 2025
Merged

Conversation

QuLogic
Copy link
Member

PR summary

This also has the side-effect of casting torch Tensors to NumPy arrays, whichfixes#30216. Sincestem is made up ofplot and[hv]lines whic already do this cast, this just moves it up one level which prevents doing it twice.

We don't have any testing with torch directly, so I didn't add any of that sort.

PR checklist

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've not analyzed the details, but is_check_1d compatible with unit hanling?hlines/vlines do_proces_unit_info as their first task.

@QuLogic
Copy link
MemberAuthor

I did insert this afterstem does its own_process_unit_info calls. At least there's a datetime test forstem intest_datetime that didn't seem to break.

This also has the side-effect of casting torch Tensors to NumPy arrays,whichfixesmatplotlib#30216. Since `stem` is made up of `plot` and `[hv]lines`whic already do this cast, this just moves it up one level whichprevents doing it twice.
@dstansbydstansby added this to thev3.10.4 milestoneJul 6, 2025
@dstansbydstansby merged commit947590d intomatplotlib:mainJul 6, 2025
40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 6, 2025
dstansby added a commit that referenced this pull requestJul 6, 2025
…233-on-v3.10.xBackport PR#30233 on branch v3.10.x (Check that stem input is 1D)
@QuLogicQuLogic deleted the stem-1d branchJuly 6, 2025 22:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.4
Development

Successfully merging this pull request may close these issues.

[Bug]: stem complaining about PyTorch's Tensor
3 participants
@QuLogic@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp