Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
ENH: Add properties position_centers and tops to BarContainer#30226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
timhoffm wants to merge1 commit intomatplotlib:mainChoose a base branch fromtimhoffm:barcontainer_props
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+48 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
These will be useful if one wants to put additional things on the bars.
Noted in#30224 (comment), which this will simplify because instad of
we can then simply do
Naming: The naming has to work for horizontal and vertical bars.
position_centers
: I useposition as the non-data coordinate. This is consistent with the naming inhttps://matplotlib.org/devdocs/api/_as_gen/matplotlib.axes.Axes.grouped_bar.html (bar()
/barh()
usex
/y
, which doesn't generalize to orientation.I intentionally chose
position_centers
overcenter_positions
, becausecenter_position
could be misinterpreted as the (x, y) coordinates of the centers of the bar rectangles.tops
:https://matplotlib.org/devdocs/api/_as_gen/matplotlib.axes.Axes.grouped_bar.html universally usesheights
and the upper end of theheight
is reasonably thetop
. I think its bearable to have this naming also in the face of potentially horizontal bars.