Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix polar aspect#30207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mrinalcodez wants to merge5 commits intomatplotlib:mainChoose a base branch frommrinalcodez:fix-polar-aspect
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix polar aspect#30207
+81 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…tortion of the plot
…plotlib into fix-polar-aspect
@@ -169,6 +169,7 @@ class PolarAxes(Axes): | |||
defget_rlabel_position(self)->float: ... | |||
defset_rlabel_position(self,value:float)->None: ... | |||
defset_rscale(self,*args,**kwargs)->None: ... | |||
defset_yticks(self,*args,**kwargs)->None: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry I did not follow the mypy syntax here for the python function it would be
def set_yticks(
self,
ticks: Sequence[float],
labels: Sequence[str] | None = ...,
*,
minor: bool = ...
) -> list[float]: ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
This pull request addresses issue#30164 by refining the PolarAxes projection to fix autoscaling issues with radial ticks and improve aspect ratio handling and tick label visibility in polar plots. The update adds improved handling of axis aspect and radial tick formatting for more consistent and customizable polar plots.
A dedicated test script,
test_polaraxes.py
, has been added to verify the correctness and stability of these changes.Below is an example image showcasing the improvements in polar plot appearance after applying this patch:
PR checklist
test_polaraxes.py
Release notes