NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Update type hints to fix #30160#30193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

ZPyrolink wants to merge12 commits intomatplotlib:main

base:main

Choose a base branch

fromZPyrolink:main

Open

Update type hints to fix #30160#30193

ZPyrolink wants to merge12 commits intomatplotlib:mainfromZPyrolink:main

+276 −117

Conversation

Copy link

ZPyrolink commentedJun 20, 2025

PR summary

This PR update thetools/boilerplate.py for

Autogenerate getter / setter:
- xlim
- ylim

This PR updatelib/matplotlib/pyplot.py

Replace*args, **kwargs with the real signature for the following methods:
- savefig
- set_loglevel
Add overloads for the following methods:
- subplot
- show

This PR add tests for checking the pyplot signature

test_setloglevel_signature:plt.set_loglevel$\iff$mpl.set_loglevel
test_polar_signature:plt.polar$\iff$Axes.plot

PR checklist

Closes[MNT]: pyplot type hints #30160
Changed code istested

Additional comments

Not done on this PR (because not directly linked to the Issue) but why not replace level: str with level: Literal[...]

CorenthinZ added8 commits

June 18, 2025 13:55

Add xlim / ylim autogeneration

e57b321

- Create get_signature method- Create AXES_GETTER_SETTER_TEMPLATE- Create call_param method on generate_function

Create tests

608b51f

Update polar and set_loglevel signature on pyplot.py

41b701b

Create show overloads on pyplot.py

1ff2bd2

Update savefig signature on pyplot.py

b863ba2

Create subplot overloads on pyplot.py

f4693e3

Update test_pyplot.py to include type on signature

4ea0ff8

Add type hint on polar and set_loglevel on pyplot.py. Correct polar c…

92dc045

…ontent

github-actionsbot added the topic: pyplot API label

Jun 20, 2025

github-actionsbot reviewed

Jun 20, 2025

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Remove old xlim and ylim

66ee071

QuLogic reviewed

Jun 20, 2025

View reviewed changes

lib/matplotlib/pyplot.py OutdatedShow resolvedHide resolved

CorenthinZ added3 commits

June 20, 2025 21:06

Revert superfluous changes

e46252a

Format with ruff

64e7921

Re-remove (bad old revert)

00624ec

melissawm added this toFirst Time Contributors

Jun 20, 2025

melissawm moved this toNeeds review inFirst Time Contributors

Jun 20, 2025

Copy link

Member

timhoffm commentedJun 20, 2025

This PR does a lot of independent things. Splitting up into individual PRs for the different topics would make reviewing simpler. There are at least the three "This PR ..." blocks if not the five top-level bullet points.