Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Abstract base class for Normalize#30178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
After discussion on this weeks call I think we should go with the ABC flavor. Given:
If we are going to bring in a new language feature we should do that when it brings in a clear benefit so we should stick with ABC. |
The docs failure is real, The new class needs to be manually added to the rst. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
modulo fixing the docs build.
If I'm not mistaken, once you put the base class into Sphinx, you can replace the duplicate docstrings in the no-longer-base class with |
This PR is an alternative to#30149
It is created so that we can contrast full implementations of a protocol vs an abstract base class in light of the comment here#30149 (comment)
For context on why this is required, see the comment on the MultiNorm PR#29876 (comment)