Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Prepare to turn matplotlib.style into a plain module.#30163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6dbfc13 to9d16b89Comparemypy seems unhappy even though these are clearly listed in |
I suspect it is the issue is that it is missing from the meson.build. |
Ah, thanks for pointing it out. Dropping style/meson.build is probably another good reason for the change :) |
Having matplotlib.style be a package with the entire implementation inmatplotlib.style.core is a bit overkill, and also makes it slightlyawkward that USER_LIBRARY_PATHS is effectively a public API (clearlyintended as so, per the comment, even though we may do it differentlynowadays...) but only available in matplotlib.style.core, whereaseverything else is re-exported by matplotlib.style.Prepare to flatten the implementation by deprecatingmatplotlib.style.core and reexporting USER_LIBRARY_PATHS inmatplotlib.style. Once the deprecation elapses, we'll be able tomove the implementation into a plain matplotlib/style.py module.
68c67c9 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Having matplotlib.style be a package with the entire implementation in matplotlib.style.core is a bit overkill, and also makes it slightly awkward that USER_LIBRARY_PATHS is effectively a public API (clearly intended as so, per the comment, even though we may do it differently nowadays...) but only available in matplotlib.style.core, whereas everything else is re-exported by matplotlib.style.
Prepare to flatten the implementation by deprecating matplotlib.style.core and reexporting USER_LIBRARY_PATHS in matplotlib.style. Once the deprecation elapses, we'll be able to move the implementation into a plain matplotlib/style.py module.
PR summary
PR checklist