Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
TST: Fix runtime error checking NaN input to format_cursor_data#30162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
QuLogic commentedJun 11, 2025
Looks like the Python 3.13 builds are hitting the broken installationpython/cpython#135151 |
anntzer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't the warning catch happen in format_cursor_data (or _format_cursor_data_override) so that it indeed doesn't get emitted when the user mouseovers a nan pixel?
Feel free to dismiss if I missed something.
QuLogic commentedJun 12, 2025
Ah, I wasn't sure if that was something that would happen on purpose; if so, then yes we can move it there. |
anntzer commentedJun 12, 2025
@timhoffm Still OK with the new version? |
716d046 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…ut to format_cursor_data
…162-on-v3.10.xBackport PR#30162 on branch v3.10.x (TST: Fix runtime error checking NaN input to format_cursor_data)
PR summary
This seems to have changed in NumPy 2.3.0, only on Windows, but there's no reason to not catch this in the test always.
PR checklist