Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove ttconv backwards-compatibility code#30145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:text-overhaulfromQuLogic:remove-ttconv
Jun 19, 2025

Conversation

QuLogic
Copy link
Member

PR summary

When ttconv was replaced by pure Python code, several bits of compatibility code were left in in#18181. This removes those code chunks, as the test images will already be regenerated as part of the larger font work.

As this only affects PDF, and it's only minor rounding/duplicate vertices, the differences are generally only a single pixel for 1 character out of 3 or 4.

PR checklist

Copy link
Member

@oscargusoscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor thing that can be skipped to save CI, but other than that seems fine.

@QuLogicQuLogic moved this fromWaiting for other PR toReady for Review inFont and text overhaulJun 5, 2025
@tacaswell
Copy link
Member

Please drop the last commit and self-merge.

@QuLogicQuLogic merged commit7dafe63 intomatplotlib:text-overhaulJun 19, 2025
15 of 31 checks passed
@github-project-automationgithub-project-automationbot moved this fromReady for Review toDone inFont and text overhaulJun 19, 2025
@QuLogicQuLogic deleted the remove-ttconv branchJune 19, 2025 18:49
@QuLogic
Copy link
MemberAuthor

Not going to wait for CI, because it's just going to fail, and then run again when merged, and fail there too...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
Status: Done
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@tacaswell@oscargus@anntzer
[8]ページ先頭
©2009-2025 Movatter.jp