Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix: Add [global] to pybind11 in dev requirements for Windows compati…#30124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
PR summary
When installing
matplotlibin editable mode on Windows, the build fails with the error:fatal error C1083: Cannot open include file: 'pybind11/pybind11.h': No such file or directoryThis issue arises because the standard
pybind11installation does not place headers in a globally accessible location. By specifyingpybind11[global], the headers are installed in a location where build tools like Meson can find them, resolving the compilation error.Summary of changes:
requirements/dev.txtto requirepybind11[global]instead of justpybind11.References:
Seepybind11 documentation on global installation.
PR checklist