Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
CI: Skip jobs on forks#30118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
CI: Skip jobs on forks#30118
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Only downside is that if you want to use CI to check wheel buliding youmust open a PR or remove the check, but I think that is a reasonable trade off to avoid burning the commute on every push (there is a reason we only do it on PRs in an opt-in basis). |
and we might as well backport this to all of our active branches. |
| contains(github.event.pull_request.labels.*.name, | ||
| 'CI: Run cibuildwheel') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Misaligned.
| contains(github.event.pull_request.labels.*.name, | |
| 'CI: Run cibuildwheel') | |
| contains(github.event.pull_request.labels.*.name, | |
| 'CI: Run cibuildwheel') |
| contains(github.event.pull_request.labels.*.name, | ||
| 'CI: Run cibuildwheel') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| contains(github.event.pull_request.labels.*.name, | |
| 'CI: Run cibuildwheel') | |
| contains(github.event.pull_request.labels.*.name, | |
| 'CI: Run cibuildwheel') |
PR summary
Tests are skipped when pushing changes to a fork, but some other jobs are run. Especially Build CI wheels is a bit unnecessary to run on forks. Also, the CodeQL job is executed periodically on forks, which may lead to emails, but if nothing else waste of compute resources.
PR checklist