Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Refactor for issue 28444#30115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
vagnermcj wants to merge8 commits intomatplotlib:mainChoose a base branch fromvagnermcj:refactor-for-issue-28444
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+121 −13
Open
Refactor for issue 28444#30115
Changes fromall commits
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
56ec318
Bbox refactor
vagnermcjb6e8b43
ruff checks
vagnermcj8d39945
Update meson.build
vagnermcj109aadc
Fixing auto_scale_lim
vagnermcj7b8c5e1
Updating tests
vagnermcj224f9c0
Revert "Updating tests"
vagnermcj8f9e5d6
Implementing update_from_bbox
vagnermcj8dc8584
Fix in Docstring
vagnermcjFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletionslib/matplotlib/transforms.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletionslib/matplotlib/transforms.pyi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletionslib/mpl_toolkits/mplot3d/art3d.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
35 changes: 22 additions & 13 deletionslib/mpl_toolkits/mplot3d/axes3d.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletionslib/mpl_toolkits/mplot3d/bbox3d.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
from matplotlib.transforms import Bbox | ||
class _Bbox3d: | ||
""" | ||
A helper class to represent a 3D bounding box. | ||
This class stores the minimum and maximum extents of data in 3D space | ||
(xmin, xmax, ymin, ymax, zmin, zmax). It provides methods to convert | ||
these extents into 2D bounding boxes (`Bbox`) for compatibility with | ||
existing matplotlib functionality. | ||
Attributes | ||
---------- | ||
xmin, xmax : float | ||
The minimum and maximum extents along the x-axis. | ||
ymin, ymax : float | ||
The minimum and maximum extents along the y-axis. | ||
zmin, zmax : float | ||
The minimum and maximum extents along the z-axis. | ||
Methods | ||
------- | ||
to_bbox_xy(): | ||
Converts the x and y extents into a 2D `Bbox`. | ||
to_bbox_zz(): | ||
Converts the z extents into a 2D `Bbox`, with the y-component unused. | ||
""" | ||
def __init__(self, points): | ||
((self.xmin, self.xmax), | ||
(self.ymin, self.ymax), | ||
(self.zmin, self.zmax)) = points | ||
def to_bbox_xy(self): | ||
return Bbox(((self.xmin, self.ymin), (self.xmax, self.ymax))) | ||
def to_bbox_zz(self): | ||
# first component contains z, second is unused | ||
return Bbox(((self.zmin, 0), (self.zmax, 0))) |
1 change: 1 addition & 0 deletionslib/mpl_toolkits/mplot3d/meson.build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.