Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix _is_tensorflow_array.#30114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
anntzer wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromanntzer:ita
Open

Conversation

anntzer
Copy link
Contributor

The previous implementation was clearly wrong (the isinstance check would raise TypeError as the second argument would be a bool), but the tests didn't catch that because the bug led to _is_tensorflow_array returning False, then _unpack_to_numpy returning the original input, and then assert_array_equal implicitly convertingresult by calling__array__ on it. Fix the test by explicitly checking thatresult is indeed a numpy array, and also fix _is_tensorflow_array with more restrictive exception catching (also applied to _is_torch_array, _is_jax_array, and _is_pandas_dataframe, while we're at it).

PR summary

PR checklist

The previous implementation was clearly wrong (the isinstance checkwould raise TypeError as the second argument would be a bool), but thetests didn't catch that because the bug led to _is_tensorflow_arrayreturning False, then _unpack_to_numpy returning the original input,and then assert_array_equal implicitly converting `result` by calling`__array__` on it.  Fix the test by explicitly checking that `result`is indeed a numpy array, and also fix _is_tensorflow_array with morerestrictive exception catching (also applied to _is_torch_array,_is_jax_array, and _is_pandas_dataframe, while we're at it).
@anntzeranntzer added this to thev3.10.4 milestoneMay 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.4
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp