Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Close star polygons#30069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Close star polygons#30069
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As I happened to note that the clip_path-test was updated: is this enough and the newly added test can be removed? Of course, it can be good to have an explicit test for this (in case someone modifies the clip_path-test and removes the hatch.
Perhaps the clip_path test is enough. I was planning to make a zoomed-in test to really show the change, but of course the hatch markers are in display coordinates so you have to zoom in the file viewer and not when producing the image. |
When '*' hatching was used and you zoomed in (especially in vectorformats), the top of the star was not joined quite right. Usingclosepoly as the last operation fixes this.
f4346b5 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
When '*' hatching was used and you zoomed in (especially in vector formats), the top of the star was not joined quite right. Using closepoly as the last operation fixes this.
Before:
After:
See also#29392 which fills the stars.