Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Use antialiasing when comparing pdf files#30068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Render at 600dpi and scale down to 150dpi.
Perhaps this is causing the EPS failures
I didn't check, but did all the baselines get updated because they were in fact already slightly invalid but the errors were hidden by the low resolution? If so, does it mean that the regeneration of most baselines arising from the current work to update freetype & parts of the text rendering stack would mean that after they get merged (perhaps not so quickly...), this PR would no longer need to further update them? Perhaps as a temporary workaround (to limit baseline updates) we could have two test formats, ".pdf" and ".aa600.pdf" where only the latter would be tested after AA rasterization at 600dpi? |
Uh oh!
There was an error while loading.Please reload this page.
Render at 600dpi and scale down to 150dpi.
The low-resolution non-antialiased rendering is convenient in that it hides minor font differences, but it can hide actual rendering errors and cause problems. For example,#29392 needs to change multiple baseline files because of minor differences only visible because of the low-resolution rasterisation.