Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Move test data into a single subdirectory#30061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me - I left a copule of comments/suggestions for minor improvement, but don't think they're blockers.
Uh oh!
There was an error while loading.Please reload this page.
| @@ -33,15 +33,15 @@ def build_sphinx_html(source_dir, doctree_dir, html_dir, extra_args=None): | |||
| def test_tinypages(tmp_path): | |||
| shutil.copytree(Path(__file__).parent / 'tinypages', tmp_path, | |||
| shutil.copytree(Path(__file__).parent / 'data/tinypages', tmp_path, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While all these lines are being changed, it might be worth adding "tinypages_data_path = Path(file).parent / "data" / "tinypages"` variable to the file and re-using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, done.
Consolidating these files make it easier to remove or restore themwithout having to track each one individually.
903d537 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Consolidating these files make it easier to remove or restore them without having to track each one individually.
The main reason for this is#29093, wherein we canrestore the test data (to the temporary testing environment) more easily if it's a single subdirectory.
PR checklist