Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Drop the FT2Font intermediate buffer.#30059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
anntzer wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromanntzer:ft-direct-render

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedMay 16, 2025
edited
Loading

Directly render FT glyphs to the Agg buffer. In particular, this naturally provides, with no extra work, subpixel positioning of glyphs (closing#29551) (this could also have been implemented in the old framework, but would have required careful tracking of subpixel offets).

Note that rendering of mathtext boxes (e.g., fraction bars) is currently missing, but should be "easy" (the main question being whether/how to ensure proper hinting/alignment to pixel edges in the horizontal or vertical output cases). Likewise, all baseline images should be regenerated. Finally, the new APIs added to FT2Font are likely up to bikeshedding (but they are all private).

In practice this should get included (if we agree to go this way) into the FreeType update (#29816). This would also supersede the patch advertised at#29816 (comment).

test modified from#29551 to also include mathtext:

importmatplotlib.pyplotaspltimportmatplotlib.animationasmanimfig=plt.figure(figsize=(2,2))ts= [fig.text(0,0,'$ABC123$'),fig.text(0,0.2,'ABC123'),]change=0.001defupdate(*args,**kwargs):globalchangefortints:x,y=t.get_position()ifnot (0<=x<=1and0<=y<=1):change*=-1t.set_x(x+change)t.set_y(y+change)returntsani=manim.FuncAnimation(fig,update,interval=20,frames=int(2/change),cache_frame_data=False)ani.save('text.gif')

PR summary

PR checklist

@story645
Copy link
Member

story645 commentedMay 16, 2025
edited
Loading

Would you be open to using a tracking issue or project board for the font work (sample categories: draft, waiting on other PRs, ready for review, please review first)?

I think breaking everything up into small PRs is fantastic but I'm finding it a bit overwhelming to keep track of the order for reviewing things (and figure I'm not alone here) and how these PRs relate to each other.

@anntzer
Copy link
ContributorAuthor

anntzer commentedMay 16, 2025
edited
Loading

Sure, I'll do that. I'm sorry for the mess, but this is basically me trying to remember all the patches or even just ideas I have accumulated over the years that went nowhere because they would thrash all the baseline images, and that I now try to present given that I see an opportunity with the FreeType upgrade. Also, some of them are notfully complete patches but things that I believe can be made complete with relatively little effort (for some value of "little effort"...) simply because I do not have the time now to finalize them but want to put them up for discussion as the underlying idea should be clear.

Edit: seethe wiki; attn@QuLogic as well too.

story645 reacted with heart emoji

@story645
Copy link
Member

story645 commentedMay 16, 2025
edited
Loading

I'm sorry for the mess, but

No apologies needed, I commend you for taking advantage of the freetype upgrade. And thanks for the wiki, though some reason can't link cleanly☹️

@anntzer
Copy link
ContributorAuthor

link fixed

story645 reacted with thumbs up emoji

@anntzeranntzerforce-pushed theft-direct-render branch 3 times, most recently fromd44360f to66fdae0CompareMay 17, 2025 09:55
@anntzer
Copy link
ContributorAuthor

Edit: fraction bar rendering has been added too.

@QuLogic
Copy link
Member

A few warnings from compiling locally:

[2/4] Compiling C++ object src/ft2font.cpython-313-x86_64-linux-gnu.so.p/ft2font_wrapper.cpp.o../../src/ft2font_wrapper.cpp: In lambda function:../../src/ft2font_wrapper.cpp:1785:22: warning: unused variable ‘error’ [-Wunused-variable] 1785 |             if (auto error = FT_Load_Glyph(face, idx, static_cast<FT_Int32>(flags))) {      |                      ^~~~~../../src/ft2font_wrapper.cpp:1788:22: warning: unused variable ‘error’ [-Wunused-variable] 1788 |             if (auto error = FT_Render_Glyph(face->glyph, FT_RENDER_MODE_NORMAL)) {      |                      ^~~~~../../src/ft2font_wrapper.cpp: In lambda function:../../src/ft2font_wrapper.cpp:1804:26: warning: unused variable ‘error’ [-Wunused-variable] 1804 |                 if (auto error = FT_Glyph_To_Bitmap(&g, FT_RENDER_MODE_NORMAL, &origin, 1)) {      |                          ^~~~~

@anntzer
Copy link
ContributorAuthor

This is semi-intentional: if these checks fail (error > 0) then the error should really be raised using throw_ft_error, not with a plain raise as I currently do, but throw_ft_error is not visible from ft2font_wrapper.cpp so some code needs to be moved around, e.g. make throw_ft_error an inline function defined in ft2font.h, or move the new implementations into real C++ FT2Font methods in ft2font.cpp and add wrapper lambdas in ft2font_wrapper.cpp, or (would be my preferred choice) switch error checking to the FT_CHECK macro used in mplcairo (see mplcairo's macros.h).
I left the warning as is just to keep this as a side discussion point, but it can trivially be suppressed by not capturing the error value too.

Directly render FT glyphs to the Agg buffer.  In particular, thisnaturally provides, with no extra work, subpixel positioning of glyphs(which could also have been implemented in the old framework, but wouldhave required careful tracking of subpixel offets).Note that all baseline images should be regenerated.  The new APIs addedto FT2Font are also up to bikeshedding (but they are all private).
@QuLogic
Copy link
Member

On a side note, I'm in favour of this in general as removing the intermediate buffer will make emoji/colour glyphs easier since they won't need to go through it.

anntzer reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@story645@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp