Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Setting imshow(animated=True) still show does not show an image#30052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 8 commits intomatplotlib:mainfromalphanoobie:minor-issue-4
Dec 8, 2025

Conversation

@alphanoobie
Copy link
Contributor

fixes#18985

PR summary

  • The suggested patch does solve the problem mentioned in the issue.
  • Tests for checking if the image is still drawn when animate=True

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@rcomerrcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@alphanoobie thank you for your contribution and sorry that nobody responded sooner. This PR looks good and I just have some suggestions about the test.

@rcomer
Copy link
Member

Hi@alphanoobie do you think you will have time to come back to this?

@rcomer
Copy link
Member

From the links it looks like this was part of a class project, so I suspect that@alphanoobie has moved on with their life. I think this was a quality contribution and so it would be good to get it in anyway - it stalled because we didn't get around to reviewing it sooner. My review suggestions above do not affect the functionality or intent of the test.

What do other devs think?

Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
@timhoffmtimhoffm merged commit08236ae intomatplotlib:mainDec 8, 2025
33 of 36 checks passed
@rcomerrcomer added this to thev3.11.0 milestoneDec 8, 2025
@QuLogicQuLogic moved this fromWaiting for author toMerged inFirst Time ContributorsDec 8, 2025
has2k1 pushed a commit to has2k1/matplotlib that referenced this pull requestDec 11, 2025
…lotlib#30052)---------Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@rcomerrcomerrcomer approved these changes

Assignees

No one assigned

Projects

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Why does setting imshow(animated=True) still show an image?

3 participants

@alphanoobie@rcomer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp