Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CI: try running the precommit hooks on GHA#30045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromtacaswell:ci/drop_precommit.ci
May 16, 2025

Conversation

tacaswell
Copy link
Member

I think it is a security risk that we have given precommit.ci a token with write access to the main repo.

If this works as expected we will get all the upsides of the current setup (see a report of precommit in CI) with none of the downsides (un-trusted entity has write permissions).

@tacaswelltacaswell added this to thev3.11.0 milestoneMay 12, 2025
@tacaswelltacaswell marked this pull request as ready for reviewMay 16, 2025 01:03
@tacaswell
Copy link
MemberAuthor

After we merge this I'll revoke the permission of the precommit app.

Copy link
Member

@oscargusoscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems to work well!

(A bit slower since everything has to be installed, but clearly not an issue in practice.)

@timhoffmtimhoffm merged commit759765c intomatplotlib:mainMay 16, 2025
37 checks passed
@tacaswelltacaswell deleted the ci/drop_precommit.ci branchMay 16, 2025 16:52
@tacaswell
Copy link
MemberAuthor

I have suspended the app, lets see what breaks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@timhoffm@oscargus

[8]ページ先頭

©2009-2025 Movatter.jp