Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
CI: try running the precommit hooks on GHA#30045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
After we merge this I'll revoke the permission of the precommit app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems to work well!
(A bit slower since everything has to be installed, but clearly not an issue in practice.)
759765c
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
I have suspended the app, lets see what breaks. |
I think it is a security risk that we have given precommit.ci a token with write access to the main repo.
If this works as expected we will get all the upsides of the current setup (see a report of precommit in CI) with none of the downsides (un-trusted entity has write permissions).