Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Replace FT2Image by plain numpy arrays.#30044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromanntzer:ufi
May 24, 2025
Merged

Conversation

anntzer
Copy link
Contributor

FT2Image predates numpy, but we don't really need to maintain our own 2D buffer class nowadays.

PR summary

PR checklist

@tacaswell
Copy link
Member

Failures look related and real, but I have no good guess as to why not on osx.

@anntzeranntzerforce-pushed theufi branch 2 times, most recently fromfc3e947 toc69331bCompareMay 12, 2025 19:51
@anntzer
Copy link
ContributorAuthor

I forgot to zero-initialize the FT2Image. Fixed.

@QuLogic
Copy link
Member

QuLogic commentedMay 17, 2025•
edited
Loading

If we end up doing#30059, does that mean this PR is also not necessary (other than applying a deprecation, probably)?

@anntzer
Copy link
ContributorAuthor

Indeed, but I didn't remove this PR as 1) the deprecation will still be needed anyways, and 2) it's a much simpler PR, which can hopefully get in faster if#30059 gets stalled.

@timhoffmtimhoffm merged commitdef8fa4 intomatplotlib:mainMay 24, 2025
41 checks passed
@anntzeranntzer deleted the ufi branchMay 24, 2025 08:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@tacaswell@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp