Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove cutout for missing font file in PdfFile._embedTeXFont.#30036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If fontfile is None, an error would already have been raised earlier indviFontName (which explicitly checks for this case).(The cutout in _embedTeXFont was introduced first, ined0066f (2009),but support for that case appears to have been broken a bit later andthe check in dviFontName was then introduced in4fcc0e7 (2016) where itsimply improved the clarity of the exception ultimately raised.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense. Reasons for the font to not exist include the pdftexDownloadBase14 option mentioned in this warning and fonts that lack a Type-1 version. My guess is that both are very rare cases, and the error message currently raised is probably good enough.
6db18d5 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
If fontfile is None, an error would already have been raised earlier in dviFontName (which explicitly checks for this case).
(The cutout in _embedTeXFont was introduced first, ined0066f (2009), but support for that case appears to have been broken a bit later and the check in dviFontName was then introduced in4fcc0e7 (2016) where it simply improved the clarity of the exception ultimately raised. -- attn@jkseppan, who wrote both commits?)
Noted in relation to#29807.
PR summary
PR checklist