Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make PdfFile font-related attributes private.#30027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@anntzer please rerun. The test issues come from a broken snowballstemmer release 3.0.0, which now has been yanked and a fixed version published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
People could have overwritten the attributes, for which this is not backwards compatible (no property setter). But I regard this as highly unlikely so that I'm ok with this as is.
They are clearly intended for internal use, and we may want to changetheir internal representation in the future to support xetex/luatex(which expose more font types).
jklymak commentedMay 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
99a521b intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
They are clearly intended for internal use, and we may want to change their internal representation in the future to support xetex/luatex (which expose more font types).
PR summary
PR checklist