Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enable linting of .pyi files#30006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromdstansby:lint-pyi
May 9, 2025
Merged

Conversation

dstansby
Copy link
Member

Enables linting of .pyi files. Most of the fixes here are line length, other fixes are:

  • Fix__all__ in__init__.pyi
  • Remove unused imports

@QuLogic
Copy link
Member

@ksunden did not wrap.pyi files at the default 88 characters, so this might cause a bit of excess churn.

@dstansbydstansby marked this pull request as ready for reviewMay 6, 2025 08:40
@oscargus
Copy link
Member

so this might cause a bit of excess churn.

Worth it to me. One time effort that is annoying, but still...

@QuLogicQuLogic requested a review fromksundenMay 7, 2025 02:46
@ksunden
Copy link
Member

For the record, the reason I did not wrap at 88 is because the official python style guide for typing specifies 130 characters.

https://typing.python.org/en/latest/guides/writing_stubs.html#maximum-line-length

I don't have too strong of an opinion, but went with the standard for the filetype.

@oscargus
Copy link
Member

Interesting. Seems like it is not possible to configure different line lengths for pyi and py files (if I read the documentation correctly). This seems like a good motivation to support that though.

@timhoffm
Copy link
Member

You could only make a separate run with different settings for pyi.

@dstansby
Copy link
MemberAuthor

For the record, the reason I did not wrap at 88 is because the official python style guide for typing specifies 130 characters.

Ah, I didn't know this! In that case I've added a exclusion for rule E501 (line length) for .pyi files, but left the rest enabled.

@tacaswelltacaswell added this to thev3.11.0 milestoneMay 9, 2025
@timhoffmtimhoffm merged commit75d9199 intomatplotlib:mainMay 9, 2025
38 of 40 checks passed
@dstansbydstansby deleted the lint-pyi branchMay 10, 2025 08:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

@oscargusoscargusoscargus approved these changes

@ksundenksundenAwaiting requested review from ksunden

Assignees
No one assigned
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

6 participants
@dstansby@QuLogic@oscargus@ksunden@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp