Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix typo: missing singlequote in unrecognized backend exception#29995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:mainfromNicoWeio:missing-singlequote
May 1, 2025

Conversation

NicoWeio
Copy link
Contributor

PR summary

I hope I don't bother you with thistiny PR, but I'd like to have typos addressed eventually. :)
Using some crude RegEx searches (f"'\{.+" etc.), I made sure that no similar typos exist.

This is the code in question:

# Then check if it is a backend name.
try:
returnself.resolve_backend(gui_or_backend)
exceptException:# KeyError ?
raiseRuntimeError(
f"'{gui_or_backend} is not a recognised GUI loop or backend name")

I cross-checked the code style with similar messages in the same file:

ifguiisNone:
raiseRuntimeError(f"'{backend}' is not a recognised backend name")

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@WeatherGodWeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pretty sure the test failures are unrelated to the changes that are here.

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for the PR - always helpful to have small fixes like this 😄

NicoWeio reacted with heart emoji
@dstansbydstansby added this to thev3.10.2 milestoneMay 1, 2025
@dstansbydstansby merged commitfa3e9da intomatplotlib:mainMay 1, 2025
37 of 39 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 1, 2025
@NicoWeioNicoWeio deleted the missing-singlequote branchMay 1, 2025 15:18
rcomer added a commit that referenced this pull requestMay 1, 2025
…995-on-v3.10.xBackport PR#29995 on branch v3.10.x (Fix typo: missing singlequote in unrecognized backend exception)
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@WeatherGodWeatherGodWeatherGod approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

3 participants
@NicoWeio@WeatherGod@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp