Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Trigger events via standard callbacks in widget testing.#29993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Sending actual events through the whole event processing pipeline is amore complete test, reveals a few minor issues (see changes below), andavoids being linked to the rather nonstandard widget method names("press" or "_click"?).The coordinates in the "move first vertex after completing the polygon"subtest of test_polygon_selector(draw_bounding_box=True) were alteredbecause the original coordinates would actually not work in a real case,as the mouse-drag would actually also trigger the polygon-rescalingbehavior.The coordinates in test_rectangle_{drag,resize} were altered because forthe original coordinates, the click_and_drag would actually be ignore()ddue to starting (just) outside of the axes.| @@ -137,7 +135,7 @@ def test_rectangle_drag(ax, drag_from_anywhere, new_center): | |||
| tool = widgets.RectangleSelector(ax, interactive=True, | |||
| drag_from_anywhere=drag_from_anywhere) | |||
| # Create rectangle | |||
| click_and_drag(tool, start=(0, 10), end=(100, 120)) | |||
| click_and_drag(tool, start=(10, 10), end=(90, 120)) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The positions in the last part of this test are also outside both before and after rectangles, so just checking if those are still valid, or are they actually outside theAxes just as these were (and thus not checking what was intended)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The axes default to ranging from 0 to 200, so the last part's rectangles are within the axes.
👍 to removing |
The problem is that right now do_event takes a (not-standardized) widget method name as parameter. I guess, sure, we could completely change the signature and have a private |
Sending actual events through the whole event processing pipeline is a more complete test, reveals a few minor issues (see changes below), and avoids being linked to the rather nonstandard widget method names ("press" or "_click"?).
The coordinates in the "move first vertex after completing the polygon" subtest of test_polygon_selector(draw_bounding_box=True) were altered because the original coordinates would actually not work in a real case, as the mouse-drag would actually also trigger the polygon-rescaling behavior.
The coordinates in test_rectangle_{drag,resize} were altered because for the original coordinates, the click_and_drag would actually be ignore()d due to starting (just) outside of the axes.
Closes#22720.
PR summary
PR checklist