Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update pinned oldest win image on azure#29992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 3 commits intomatplotlib:mainfromtimhoffm:update-winimage
May 5, 2025

Conversation

timhoffm
Copy link
Member

The windows-2019 image will be deprecated on 1.6.2025 (#29797 (comment)). Also, this is a test whether the timeouts#29797 are related to the windows-2019 image.

jayaddison reacted with thumbs up emoji
The windows-2019 image will be deprecated on 1.6.2025.Also, this is a test whether the timeoutsmatplotlib#29797 are related to thewindows-2019 image.
@timhoffm
Copy link
MemberAuthor

First run did not exhibit timeout. Force push to rerun CI. Let's check whether this is reliable by running CI multiple times.

@timhoffm
Copy link
MemberAuthor

Second run did not exhibit timeout. Force push to rerun CI.

@timhoffm
Copy link
MemberAuthor

This did not have timeouts three times in a row.

I suggest to merge this and see whether our timouts are gone. We would have to update the image in a month anyway due to the deprecation, and I don't think it's a relevant miss if we don't run the windows-2019 image.

rcomer and jayaddison reacted with thumbs up emoji

@timhoffmtimhoffm marked this pull request as draftMay 1, 2025 08:39
@timhoffmtimhoffm marked this pull request as ready for reviewMay 1, 2025 08:40
@rcomer
Copy link
Member

There is an if-loop at line 123 that the comment states is for windows-2019. I guess that can be removed.

timhoffm reacted with thumbs up emoji

The windows-2019 image will be deprecated on 1.6.2025.Also, this is a test whether the timeoutsmatplotlib#29797 are related to thewindows-2019 image.
@dstansbydstansby added this to thev3.10-doc milestoneMay 5, 2025
@dstansby
Copy link
Member

dstansby commentedMay 5, 2025
edited
Loading

I'm guessing but not 100% this wants to be backported, so I've milestoned for that on the basis that it's easier to have the backports opened and close them if not wanted than having to manually backport.

@dstansbydstansby merged commitab102c0 intomatplotlib:mainMay 5, 2025
40 checks passed
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ab102c079ae0474861bbb1dcc64da436d1a84f8b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29992: Update pinned oldest win image on azure'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-29992-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR#29992 on branch v3.10.x (Update pinned oldest win image on azure)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.1-docgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ab102c079ae0474861bbb1dcc64da436d1a84f8b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29992: Update pinned oldest win image on azure'
  1. Push to a named branch:
git push YOURFORK v3.10.1-doc:auto-backport-of-pr-29992-on-v3.10.1-doc
  1. Create a PR against branch v3.10.1-doc, I would have named this PR:

"Backport PR#29992 on branch v3.10.1-doc (Update pinned oldest win image on azure)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

rcomer pushed a commit to rcomer/matplotlib that referenced this pull requestMay 5, 2025
@timhoffmtimhoffm deleted the update-winimage branchMay 5, 2025 09:58
dstansby added a commit that referenced this pull requestMay 5, 2025
….10.xBackport PR#29992 on v3.10.x: Update pinned oldest win image on azure
rcomer pushed a commit to rcomer/matplotlib that referenced this pull requestMay 5, 2025
…9992-on-v3.10.xBackport PRmatplotlib#29992 on v3.10.x: Update pinned oldest win image on azure(cherry picked from commitacb7361)
rcomer pushed a commit to rcomer/matplotlib that referenced this pull requestMay 5, 2025
… image on azureI diverged from instructions and cherry-picked the commit from thev3.10.x branch, since that produced no conflicts.(cherry picked from commitacb7361)
@rcomerrcomer modified the milestones:v3.10-doc,v3.10.2May 5, 2025
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
@timhoffm
Copy link
MemberAuthor

Note: This seems not to fix it completely. This is a run with windows-2022 and it still produces a timeout. 😢

https://dev.azure.com/matplotlib/matplotlib/_build/results?buildId=43805&view=logs&j=f92c32cd-721a-536e-3a87-a0c010db3f7f&t=18f30b55-1017-4d18-b8e0-646f3513b769

I'm not yet taking any further action, like repoening#29981, yet. Let's monitor the situation further.

rcomer reacted with eyes emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden left review comments

@dstansbydstansbydstansby approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

5 participants
@timhoffm@rcomer@dstansby@ksunden@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp