Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix typos: horizonatal -> horizontal#29979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 1 commit intomatplotlib:mainfrommartincornejo:fix-typo
Apr 28, 2025

Conversation

martincornejo
Copy link
Contributor

No description provided.

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@tacaswelltacaswell added this to thev3.10.2 milestoneApr 28, 2025
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The second reviewer should verify my understanding that this is affecting the typing machinery and bringing it inline with the current API, NOT changing the API (as if we really have a miss-spelling in our API we need to run the normal deprecation cycle).

@rcomer
Copy link
Member

The second reviewer should verify my understanding that this is affecting the typing machinery and bringing it inline with the current API, NOT changing the API (as if we really have a miss-spelling in our API we need to run the normal deprecation cycle).

Agreed. Function would raise if the miss-spelling was passed

_api.check_in_list(["horizontal","vertical"],orientation=orientation)

Copy link
Member

@rcomerrcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@rcomerrcomer merged commit919d9e9 intomatplotlib:mainApr 28, 2025
39 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestApr 28, 2025
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

3 participants
@martincornejo@rcomer@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp