Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Backport PR #29796 on branch v3.10.x: ci: rotate soon-to-be-unsupported GitHub Actions ubuntu-20.04 runner out of roster#29949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
.github/workflows/tests.yml Outdated
| - name-suffix: "(Minimum Versions)" | ||
| os: ubuntu-20.04 | ||
| python-version: '3.10' | ||
| os: ubuntu-22.04 | ||
| python-version: '3.11' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minimum version should still test Python 3.10 for the 3.10 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ooops. Do we still want the "normal" py310 on Ubuntu too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think minver should be good enough to catch py310 incompatible code.
…b Actions ubuntu-20.04 runner out of roster(cherry picked from commit0d11978)
3dfa981 to704c239Compare9a80304 intomatplotlib:v3.10.xUh oh!
There was an error while loading.Please reload this page.
Manual backport of#29796. The conflict was because
mainhas some extra lines from#29171 right before the if-loop we're removing here.cherry picked from commit0d11978