Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Parse {lua,xe}tex-generated dvi in dviread.#29939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
af451c9 to87e0ecfCompare149992b to6a177bdCompareanntzer commentedJul 10, 2025
Milestoning to 3.11 because I think this is fairly self-contained, and is already something that mplcairo could benefit from, even before#29807 adds support in the builtin backends. But feel free to remilestone if it doesn't make it in the end. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
f8d6ee7 tob987e24CompareUh oh!
There was an error while loading.Please reload this page.
9b5488f to3db0ce0CompareUh oh!
There was an error while loading.Please reload this page.
| A glyph in the dvi file. | ||
| The *x* and *y* attributes directly position the glyph. The *font*, | ||
| *glyph*, and *width* attributes are kept public for back-compatibility, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about theglyph andwidth fields? Are they used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I restored their documentation. There's not plan to deprecate them (they are useful anyways, and deprecating fields in a namedtuple is a bit annoying) so I removed the mention of backcompat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure I see the docs back again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oops, fixed now.
9b4233b intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
anntzer commentedSep 4, 2025
Thanks for the review :) |
Uh oh!
There was an error while loading.Please reload this page.
The next step after#29829 ("Rework mapping of dvi glyph indices to freetype indices.") in preparation for#29807 ("Support {lua,xe}tex as alternative usetex engine.").
luatex and xetex generate slightly different versions of dvi files (compared to plain tex and also between themselves) to give them the ability to refer to TrueType (OpenType) fonts installed system-wide. This patch implements parsing for these dialects, and adjusts the relevant classes in dvifont so that one can indeed represent these fonts and their metrics.
Minor API design point: The DviFont.path (cached) property can raise an exception if no type1 font is associated with the tex fontname. This should be rare (and not recoverable, i.e. we would fail to generate proper output in that case anyways), but it does feel a bit dirty to raise an exception in a property. I can switch that to a plain method, e.g. DviFont.get_path or DviFont.resolve_path, if desired (but then there would be a bit of asymmetry with the other (never-raising) properties DviFont.subfont and DviFont.effects). Not a very big deal, but just in case anyone has an opinion...I decided in favor of resolve_path() (with manual caching), in particular because there is a future case (#20469 pk font support) where mapping the texname to an actual font file will even require on-the-fly generation of the font file (see mktex=pk option of kpsewhich,https://linux.die.net/man/1/kpsewhich).
PR summary
PR checklist