Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Backport PR #29908 on branch v3.10.x (TST: Use text placeholders for empty legends)#29935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
meeseeksmachine wants to merge1 commit intomatplotlib:v3.10.x
base:v3.10.x
Choose a base branch
Loading
frommeeseeksmachine:auto-backport-of-pr-29908-on-v3.10.x

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR#29908: TST: Use text placeholders for empty legends

@lumberbot-applumberbot-appbot added this to thev3.10.2 milestoneApr 17, 2025
@rcomerrcomer closed thisApr 20, 2025
@rcomerrcomer reopened thisApr 20, 2025
@rcomerrcomerforce-pushed theauto-backport-of-pr-29908-on-v3.10.x branch from171d4a3 to9637932CompareApril 20, 2025 17:46
@rcomer
Copy link
Member

Rebased 🤞

@rcomer
Copy link
Member

rcomer commentedApr 20, 2025
edited
Loading

I have no idea why these tests are failing. The striped line test failure looks like

Expected
striped_line-expected

Actual
striped_line

Diff
striped_line-failed-diff

The legend seems genuinely slightly taller than in the reference.

@QuLogic
Copy link
Member

Ah, this would need#29907, which wasn't backported.

rcomer reacted with eyes emoji

@dstansby
Copy link
Member

dstansby commentedApr 24, 2025
edited
Loading

What's the preferred solution here then - backport#29907 or just update the test image here?

@QuLogic
Copy link
Member

If we're backporting#29816, then we should also do#29907, or else these images will be inconsistent between FreeType versions.

@ksunden
Copy link
Member

This is wrapped up in the freetype side of things, so not going to hold 3.10.2 on it (since we're not waiting on that for 3.10.2).

That said, may be worth getting all of these backported if we are going this route, which I think is the consensus (and my personal opinion).

@ksundenksunden modified the milestones:v3.10.2,v3.10.3May 2, 2025
@QuLogic
Copy link
Member

I decided to start a backport of#29907. If people started using thetext_placeholders fixture (probably unlikely, I'm sure), then we'd want the results to be right from the get go.

@QuLogicQuLogicforce-pushed theauto-backport-of-pr-29908-on-v3.10.x branch from9637932 to89bfa2eCompareMay 6, 2025 08:41
@timhoffm
Copy link
Member

How much will we still backport to 3.10.x? If we don't need backports that add new test images or modify the existing ones, we could leave 3.10.x on the images with text. It should reach end-of-life in the near future.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
v3.10.4
Development

Successfully merging this pull request may close these issues.

7 participants
@meeseeksmachine@rcomer@QuLogic@dstansby@ksunden@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp