Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Backport PR #29908 on branch v3.10.x (TST: Use text placeholders for empty legends)#29935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:v3.10.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
171d4a3
to9637932
CompareRebased 🤞 |
rcomer commentedApr 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ah, this would need#29907, which wasn't backported. |
dstansby commentedApr 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
What's the preferred solution here then - backport#29907 or just update the test image here? |
This is wrapped up in the freetype side of things, so not going to hold 3.10.2 on it (since we're not waiting on that for 3.10.2). That said, may be worth getting all of these backported if we are going this route, which I think is the consensus (and my personal opinion). |
I decided to start a backport of#29907. If people started using the |
9637932
to89bfa2e
CompareHow much will we still backport to 3.10.x? If we don't need backports that add new test images or modify the existing ones, we could leave 3.10.x on the images with text. It should reach end-of-life in the near future. |
Backport PR#29908: TST: Use text placeholders for empty legends