Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Allow Python native sequences in Matplotlibimsave().#29931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Yuepeng Gu <yuepengg@andrew.cmu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
6d98336 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Why did ruff not catch the style errors here (which the backport did since it's still using flake8)? |
It seems the rule According to theRuff documentation, this rule is currently marked as unstable, so Matplotlib doesn’t appear to make use of it at the moment. |
PR summary
This PR addresses issue#29183 by casting Python sequence types (e.g., lists or tuples) to
NumPyarrays during the image saving process.The implementation is inspired by PR#29203 by@gpxxlt, which currently appears to be on hold.
PR checklist