Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
TST: Use text placeholders for empty legends#29908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👍🏻 now needs a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Now that text uses placeholders, can we changelabel=" " to some actual text likelabel="foo" orlabel="label"? This feels more normal and may be less confusing when reading the test, or when taking the code and running it without placeholders for debug purposes. Thelabel=" " was only there to reduce the font-rendering impact. I don't see a reason we should keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why don't the black boxesh show up here like they do in the png?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, it just stopped after the first extension, and I didn't catch it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because thempl20 style doesn't have patch edges, I also decided to remove the forced blue colour on the bars, since they all look like single bars instead of stacked ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I also reverted the texts here to the values before966e467
92cd616 to2053e8cCompareUh oh!
There was an error while loading.Please reload this page.
These tests use `remove_text=True` and set legend labels to emptystrings. However, they are still affected by font metrics because eventhe empty string is as tall as the line height (which is calculated fromthe height of the "lp" string.)
c1a2ec4 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
PR summary
These tests use
remove_text=Trueand set legend labels to empty strings. However, they are still affected by font metrics because even the empty string is as tall as the line height (which is calculated from the height of the "lp" string.)This depends on#29907.
PR checklist