Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ensure text metric calculation always uses the text cache#29907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:text-caching
Apr 13, 2025

Conversation

QuLogic
Copy link
Member

These locations outside ofText were callingRenderer.get_text_width_height_descent directly which meant that

  1. they were not cached, and
  2. thetext_placeholders fixture did not catch their use.

Fortunately, this only affected one test figure.

PR summary

PR checklist

These locations outside of `Text` were calling`Renderer.get_text_width_height_descent` directly which meant that1. they were not cached, and 2. the `text_placeholders` fixture did notcatch their use.Fortunately, this only affected one test figure.
@QuLogic
Copy link
MemberAuthor

QuLogic commentedApr 12, 2025•
edited
Loading

Unfortunately, I missed this in#29872 because I had only tested with changing the hinting settings originally, and not with FreeType 2.13.3+mpl20 style+hinting, and only the latter changed the height significantly enough to be noticed.

@tacaswelltacaswell merged commit65d2464 intomatplotlib:mainApr 13, 2025
42 of 44 checks passed
@tacaswell
Copy link
Member

The azure failure is 3.10 timing out in a subprocess test.

@QuLogic
Copy link
MemberAuthor

@meeseeksdev backport to v3.10.x

@QuLogicQuLogic modified the milestones:v3.11.0,v3.10.2May 6, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 6, 2025
oscargus added a commit that referenced this pull requestMay 6, 2025
…907-on-v3.10.xBackport PR#29907 on branch v3.10.x (Ensure text metric calculation always uses the text cache)
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp