Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps#29895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…olorTo solve this, we needed to ensure that the caps would use thespecified ecolor independently of the globalmpl.rcParams['lines.markeredgecolor']. This was achieved bysetting the marker edge color for the caps separately, rather than relying on the global configuration.
tacaswell commentedApr 11, 2025
The default value of This is the correct fix. |
tacaswell commentedApr 11, 2025
@useidemaisachola Thank you for this fix and the test! If you can clean up the linting/whitespace issues I think this can be merged straight away. |
useidemaisachola commentedApr 12, 2025
@tacaswell ok, i can solve them! One question as this is my first PR - after i resolve the problems with the spaces i have to commit and open another PR? Or it's possible to still use this one? |
QuLogic commentedApr 12, 2025
You should continue on your branch, and pushing it here will update this PR. |
useidemaisachola commentedApr 12, 2025
@QuLogic Ok, thank you! |
useidemaisachola commentedApr 19, 2025
@tacaswell I resolved the problem with the spaces! Now it's giving some kind of error with the version of python on windows... It is something that i have to change? |
rcomer commentedApr 20, 2025
@useidemaisachola that Azure Windows test can be flakey. The failure is not caused by your change. I have re-run it to see if we can be lucky the second time. |
useidemaisachola commentedApr 25, 2025
so, now i have to resolve the conflits? |
rcomer commentedApr 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, but if you are not comfortable doing that we can handle it for you. It looks like you and and another recent PR have added new tests in the same place, so it's just a case of making sure we keep both. |
useidemaisachola commentedApr 28, 2025
Already resolved the conflit but I guess i leaved an extra line at the end of the file or something like that, because it's failing one test... it's that? |
Uh oh!
There was an error while loading.Please reload this page.
timhoffm commentedApr 28, 2025
I took the liberty to remove the extra line at the end. Tests should pass now. |
Uh oh!
There was an error while loading.Please reload this page.
lib/matplotlib/tests/test_axes.py Outdated
| y=np.sin(x) | ||
| yerr=0.1 | ||
| mpl.rcParams['lines.markeredgecolor']='green' | ||
| fig,ax=plt.subplots() | ||
| errorbars=ax.errorbar(x,y,yerr=yerr,fmt='o',capsize=5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As above:
| y=np.sin(x) | |
| yerr=0.1 | |
| mpl.rcParams['lines.markeredgecolor']='green' | |
| fig,ax=plt.subplots() | |
| errorbars=ax.errorbar(x,y,yerr=yerr,fmt='o',capsize=5) | |
| mpl.rcParams['lines.markeredgecolor']='green' | |
| fig,ax=plt.subplots() | |
| errorbars=ax.errorbar(x,np.sin(x),yerr=0.1) |
useidemaisachola commentedApr 28, 2025
ok, thank you for the tips and the help! |
useidemaisachola commentedMay 7, 2025
I have to enter the suggestion that you told me or it´s already changed in the repository? |
QuLogic commentedMay 7, 2025
You'll have to apply it yourself, either locally and push, or using the UI here. |
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
useidemaisachola commentedMay 9, 2025
ok, it gave an error but I will fix it. |
useidemaisachola commentedMay 14, 2025
I think everything it´s ok now. |
useidemaisachola commentedMay 14, 2025
Now i have to do close or something like that? |
timhoffm commentedMay 14, 2025
No. You don't have to do anything. We have policy that each PR needs two approvals by core developers. So, we're just waiting for a second review. |
useidemaisachola commentedMay 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ok, thank you. |
20bdd72 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
QuLogic commentedMay 15, 2025
Thanks@useidemaisachola! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
useidemaisachola commentedMay 15, 2025
@QuLogic Thank you so much! So can I delete already the branch? The lumberbot gave some kind of feedback... |
rcomer commentedMay 15, 2025
@useidemaisachola you can safely delete your branch. Your work is now in Matplotlib's |
useidemaisachola commentedMay 15, 2025
Ok, thank you! |
… interfere on the color of errorbar caps
…3.10.xBackport PR#29895 on branch v3.10.x (The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps)"
… interfere on the color of errorbar caps
PR summary
-This change was necessary to resolve a bug:Fixes#29780
-Color of errorbar caps now it's not affected by 'lines.markeredgecolor'.
The initial issue arose when the caps of the error bars were unintentionally adopting the color red, which was set globally in mpl.rcParams under the 'lines.markeredgecolor' parameter. This global setting was being applied to all markers, including the caps of error bars, causing the caps to appear red even when that wasn't intended.
The root cause of the problem was that the marker edge color defined globally (mpl.rcParams['lines.markeredgecolor']) was being inherited by the caps as part of the error bar plot. This caused the color of the caps to match the global red color, even when only the error bars were supposed to be red (through the ecolor parameter).
To solve this, we needed to ensure that the caps would use the specified ecolor independently of the global mpl.rcParams['lines.markeredgecolor']. This was achieved by setting the marker edge color for the caps separately, rather than relying on the global configuration.
The files that suffered alterations were _axes.py and test_axes.py.
PR checklist