Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change types for width/height to match definitions in BufferRegion#29894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kraj wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromkraj:kraj/riscv32

Conversation

kraj
Copy link

This is found with clang

Fixes
../matplotlib-3.10.1/src/_backend_agg_wrapper.cpp:253:17: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'int' in initializer list [-Wc++11-narrowing]

PR summary

PR checklist

This is found with clangFixes../matplotlib-3.10.1/src/_backend_agg_wrapper.cpp:253:17: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'int' in initializer list [-Wc++11-narrowing]
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@tacaswell
Copy link
Member

It is not immediately clear to me why we should flip both toint rather than both tounsigned int ?

@kraj
Copy link
Author

It is not immediately clear to me why we should flip both toint rather than both tounsigned int ?

this was simpler fix, tbh using unsigned int would have required more changes but it might be semantically better Idk

@oscargus
Copy link
Member

I think going to unsigned in BufferRegion is the better fix.

Internally, we use the values forattach and there,unsigned is expected.

voidattach(T* buf,unsigned width,unsigned height,int stride)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kraj@tacaswell@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp