Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MultiNorm class#29876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 19 commits intomatplotlib:mainfromtrygvrad:multivariate-plot-prapare
Aug 20, 2025
Merged

Conversation

@trygvrad
Copy link
Contributor

PR summary

This PR continues the work of#28658 and#28454, aiming toclose#14168. (Feature request: Bivariate colormapping)

This is part one of the former PR,#29221. Please see#29221 for the previous discussion

Featuresincluded in this PR:

  • AMultiNorm class. This is a subclass ofcolors.Normalize and holdsn_variate norms.
  • Testing of theMultiNorm class

Featuresnot included in this PR:

  • changes to colorizer.py needed to expose the MultiNorm class
  • Exposes the functionality provided byMultiNorm together withBivarColormap andMultivarColormap to the plotting functionsaxes.imshow(...),axes.pcolor, and `axes.pcolormesh(...)
  • Testing of the new plotting methods
  • Examples in the docs

@trygvradtrygvradforce-pushed themultivariate-plot-prapare branch from55b85e3 tof42d65bCompareApril 17, 2025 15:18
Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some minor points, plus re-pinging@timhoffm in case he has an opinion re: n_input / input_dims naming?

@trygvrad
Copy link
ContributorAuthor

Thank you for the feedback@anntzer !
Hopefully we can hear if@timhoffm has any thoughts on n_input / input_dims naming within the coming week.

@timhoffm
Copy link
Member

See#29876 (comment)

@trygvrad
Copy link
ContributorAuthor

Thank you@timhoffm
The PR should now be as we agreed (#29876 (comment)) :)

@trygvrad
Copy link
ContributorAuthor

@QuLogic Thank you again and apologies for my tardiness (I was sick)
@timhoffm Do you think you could approve this PR now?

@trygvradtrygvradforce-pushed themultivariate-plot-prapare branch from6b86d63 to32247f5CompareJune 4, 2025 21:01
@trygvrad
Copy link
ContributorAuthor

This is on hold until we sort out#30149 (Norm Protocol)
see#29876 (comment)

@trygvrad
Copy link
ContributorAuthor

I changed vmin, vmax and clip to only accept iterables or None.

It dawned on me that it will be useful to allow None, with the behavior that it does not modify the vmin/vmax/clip on the constituent norms. This will be useful for use as a default, but also be useful for users that want to combine multiple norms into a MultiNorm without modifying the limits of the norms.

@timhoffm@anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled.@QuLogic I'll take a look at the rest of your comments soon :)

@anntzer
Copy link
Contributor

@timhoffm@anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled.@QuLogic I'll take a look at the rest of your comments soon :)

Sorry I dropped the ball on this. I can try to have a look but not before the middle of the month or so.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@trygvradtrygvradforce-pushed themultivariate-plot-prapare branch fromff2eb20 tof61c06bCompareAugust 7, 2025 21:25
@trygvrad
Copy link
ContributorAuthor

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

@QuLogic
Copy link
Member

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

There are still a couple of comments that are unresolved/have no reply, at least.

trygvrad reacted with thumbs up emoji

@trygvrad
Copy link
ContributorAuthor

@QuLogic@story645 thank you for your comments and patience on this, Ibelieve i have addressed all the commentsnow, but please correct me again if there are some I have overlooked. Otherwise I look forward to your future comments :)

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@trygvradtrygvradforce-pushed themultivariate-plot-prapare branch from486a58f to3267fe9CompareAugust 16, 2025 20:42
@QuLogicQuLogic added this to thev3.11.0 milestoneAug 19, 2025
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a minor last thing,

@trygvrad
Copy link
ContributorAuthor

Just a minor last thing,

Thank you@QuLogic !

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Were you expecting a squash merge?

@trygvrad
Copy link
ContributorAuthor

Were you expecting a squash merge?

Yes, I believe a squash merge would be most suitable

@QuLogicQuLogic merged commit3a8ad1d intomatplotlib:mainAug 20, 2025
38 of 40 checks passed
@QuLogic
Copy link
Member

Thanks for working your way through this long process.

timhoffm, trygvrad, Migelo, and story645 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@story645story645story645 left review comments

@anntzeranntzeranntzer left review comments

@jklymakjklymakjklymak left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@oscargusoscargusoscargus left review comments

@QuLogicQuLogicQuLogic approved these changes

Assignees

No one assigned

Labels

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Feature request: Bivariate colormapping

7 participants

@trygvrad@timhoffm@anntzer@QuLogic@story645@jklymak@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp