Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
ENH: Add option to relpace text with boxes in image_comparision test#29871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This should be the right level of simplification when text is relevantin image comparision tests but the exact characters do not matter. Thedrawn bboxes only rely on font metrics and thus give accurate sizes,while being insensitive to rendering details.This is a minimal proof-of-concept. Exact implementation may be improved.
Looks like we crossed with#29872.
Unfortunately, relying on font metrics is not safe to avoid changes in test images. For example, if you change the hinting settings in |
Superseeded by#29872. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| """ | ||
| A helper flag to replace texts by a bounding box. This is primarily | ||
| intended for use in figure comparison tests. | ||
| For sipmlicity, the flag is evaluated at draw time and thus applies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is a spelling error in the word 'sipmlicity'; consider correcting it to 'simplicity'.
| Forsipmlicity,theflagisevaluatedatdrawtimeandthusapplies | |
| Forsimplicity,theflagisevaluatedatdrawtimeandthusapplies |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, just wanted to try what copilot review suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It didn't even manage to catch the typos in the PR title...
Uh oh!
There was an error while loading.Please reload this page.
This should be the right level of simplification when text is relevant in image comparision tests but the exact characters do not matter. The drawn bboxes only rely on font metrics and thus give accurate sizes, while being insensitive to rendering details.
Alternative to#29833.
This is a minimal proof-of-concept. Exact implementation may be improved: