Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update lib/matplotlib/stackplot.py#29853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 7 commits intomatplotlib:mainfromthedatacurious:doc-branch
Apr 7, 2025

Conversation

thedatacurious
Copy link
Contributor

PR summary

Update minimal examples in stackplot.py to improve clarity

PR checklist

Note: Unable to build doc in Github Codespace (already opened issuehere)

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@timhoffm
Copy link
Member

timhoffm commentedApr 2, 2025
edited
Loading

Thanks for the pull request! However, the existing "array-like" is sufficient, seehttps://numpy.org/doc/2.1/glossary.html#term-array_like. A pandas DataFrame is covered by this. It's not feasible to write out any array-compatible datastructure explicitly.

We would only state DataFrame explicitly if we make use of specific DataFrame features like the index, as long as we only use the column values it's a generic array-like to us.

@story645
Copy link
Member

@timhoffm I talked to@thedatacurious about this PR a bit and it stemmed from a confusion with y b/c stackplot supports both the packed stackplot(x, y=[y1, y2, y3]) and the unpacked form stackplot(x, y1, y2, y3) form.

While this PR may be doing a bit too much in its current form, I think it's fair to be a bit more explicit on allowed inputs.

@timhoffm
Copy link
Member

Sure, feel free to reopen and rephrase.

That said, I think we should more clearly specify what array-like means. But that's a separate topic (possibly a glossary entry when we revive that, and/or an :mpl-type: link).

story645 and thedatacurious reacted with thumbs up emoji

@thedatacurious
Copy link
ContributorAuthor

thedatacurious commentedApr 4, 2025
edited
Loading

@timhoffm Sure, it looks like I don't have permissions to reopen this PR, should I raise a new one?

I have rephrased the edits:
main...thedatacurious:matplotlib:doc-branch)

@jklymakjklymak reopened thisApr 4, 2025
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@timhoffm
Copy link
Member

Please fix the trailing whitespace as reported by flake8.

thedatacurious reacted with thumbs up emoji

@timhoffmtimhoffm added this to thev3.10.2 milestoneApr 7, 2025
@timhoffmtimhoffm merged commite8d58af intomatplotlib:mainApr 7, 2025
39 of 41 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestApr 7, 2025
timhoffm added a commit that referenced this pull requestApr 7, 2025
…853-on-v3.10.xBackport PR#29853 on branch v3.10.x (Update lib/matplotlib/stackplot.py)
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

4 participants
@thedatacurious@timhoffm@story645@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp