Instead of directly exposing widths, heights, depths dicts, provide a get_metrics method to access a glyph's (tex) metrics. This change is in preparation for {xe,lua}tex support, which would use an alternative metrics-loading class (TtfMetrics) where it would be excessive to load the metrics of all glyphs at once.

PR summary

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

anntzer added the topic: text/usetex label

Mar 31, 2025

github-actionsbot added the backend: pdf label

Mar 31, 2025

timhoffm reviewed

Mar 31, 2025

View reviewed changes

lib/matplotlib/dviread.pyi Outdated

		height:dict[int,int]
		depth:dict[int,int]
		def__init__(self,filename:str\|os.PathLike)->None: ...
		defget_metrics(self,int)->TexMetrics\|None: ...

Copy link

Member

timhoffmMar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	defget_metrics(self,int)->TexMetrics\|None: ...
	defget_metrics(self,idx:int)->TexMetrics\|None: ...

Copy link

ContributorAuthor

anntzerMar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks, fixed

anntzer force-pushed thetexmetrics branch 2 times, most recently fromb09d728 to3f2c7ddCompare

March 31, 2025 11:13

timhoffm approved these changes

Mar 31, 2025

View reviewed changes

tacaswell added this to thev3.11.0 milestone

Mar 31, 2025

dstansby approved these changes

Mar 31, 2025

View reviewed changes

Copy link

Member

dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just one suggestion to make the dataclass keyword argument only

lib/matplotlib/dviread.py OutdatedShow resolvedHide resolved

anntzer force-pushed thetexmetrics branch from3f2c7dd to734a3ddCompare

March 31, 2025 13:19

Copy link

ContributorAuthor

anntzer commentedMar 31, 2025

sure, done

anntzer force-pushed thetexmetrics branch from734a3dd to1801b94Compare

March 31, 2025 15:32

Switch Tfm metrics to TrueType-compatible API.

a18e072

Instead of directly exposing widths, heights, depths dicts, provide aget_metrics method to access a glyph's (tex) metrics.  This change is inpreparation for {xe,lua}tex support, which would use an alternativemetrics-loading class (`TtfMetrics`) where it would be excessive to loadthe metrics of all glyphs at once.

anntzer force-pushed thetexmetrics branch from1801b94 toa18e072Compare

March 31, 2025 20:47

Copy link

ContributorAuthor

anntzer commentedMar 31, 2025

I'm a bit at loss as to how to placate mypy here, so if someone who actually uses typing could have a look, this would be very helpful :)

TYP: work around mypy limitation

5d0adf1

Copy link

Member

tacaswell commentedMar 31, 2025

Pushed a commit that fixes it locally.

Look like this is a limitation in stubtests that does not correctly handle thekw_only=True functionality as__match_args__ is how dataclasses do some of their arg parsing in__init__.