Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: expire legend-related deprecations#29832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lib/matplotlib/legend.py Outdated
| "be discarded. This is deprecated since %(since)s and will " | ||
| "become an error in %(removal)s.")) | ||
| raise ValueError("When passing handles and labels, they must both be " | ||
| "passed positionally or both as keywords.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a better exception type thanValueError for this situation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There's no really good match. I'm inclined to go with TypeError as that is used in other cases, when the signature is not fulfilled.
Uh oh!
There was an error while loading.Please reload this page.
Rebased to pick up#29834 |
ade791f intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
PR summary
Expire the deprecations from#27175 and#27767
PR checklist