Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add language parameter to Text objects#29794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
anntzer commentedMar 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
re: adding language to draw_text: the general discussion about extensibility of renderer API applies, i.e.
|
Side point regarding allowing |
In the call a couple weeks ago, we decided to drop the new However, one followup is that |
@@ -65,7 +65,7 @@ def layout(string, font, *, kern_mode=Kerning.DEFAULT): | |||
""" | |||
x = 0 | |||
prev_glyph_idx = None | |||
char_to_font = font._get_fontmap(string) | |||
char_to_font = font._get_fontmap(string) # TODO: Pass in language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note, this function is getting rewritten with libraqm, so this is just a note for later.
lib/matplotlib/_text_helpers.py Outdated
@@ -43,7 +43,7 @@ def warn_on_missing_glyph(codepoint, fontnames): | |||
f"Matplotlib currently does not support {block} natively.") | |||
def layout(string, font, *, kern_mode=Kerning.DEFAULT): | |||
def layout(string, font,language,*, kern_mode=Kerning.DEFAULT): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These params should be kwonly? (throughout most of the PR, I think)
src/ft2font_wrapper.cpp Outdated
@@ -1,3 +1,4 @@ | |||
#include <cstddef> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why do you need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Accidental;clangd
likes to add these itself and sometimes I miss it.
3c188df
to931423b
CompareI've added a |
Also added a What's new note, though as with the other PR, it won't show the difference until |
PR summary
Along with#29695, thislanguage parameter is an additional setting that may affect text layout. As with the other PR, this is not complete, but rather something to get the API decided upon (and likely will be rebased on raqm PR after it's done.)
There are two parts to the API:
language
parameter attached toText
, and any other API that wraps it (i.e.,Axes.text
orAxes.annotate
)language
parameter in backend'sRenderer.draw_text
At the moment, for both, I have set these to
str | list[tuple[str, int, int]]
where the latter denotes a list of (language, start, end)-tuples. However, this was before I found out aboutthe font feature machinery, and it is possible that we may wish to use that syntax instead, at least for API part 1. For part 2, it's a little nicer to have the explicit types, just for passing to the FT2Font extension, but this may not be relevant to other implementations.PR checklist