Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix escaping of nulls and "0" in default filenames.#29781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lib/matplotlib/backend_bases.py Outdated
| @@ -2220,7 +2220,7 @@ def get_default_filename(self): | |||
| # Characters to be avoided in a NT path: | |||
| # https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#naming_conventions | |||
| # plus ' ' | |||
| removed_chars = r'<>:"/\|?*\0 ' | |||
| removed_chars = r'<>:"/\|?*''\0 ' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I find this a bit too clever. This seems simpler
| removed_chars=r'<>:"/\|?*''\0 ' | |
| removed_chars='<>:"/\\|?*\0 ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sure
Adding a test for this required tweaking a bit the behavior of non-GUImanagers (so that they also store the window title); note that thecomment of non-GUIs returning None was clearly wrong.
e4e85e6 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…781-on-v3.10.xBackport PR#29781 on branch v3.10.x (Fix escaping of nulls and "0" in default filenames.)
Adding a test for this required tweaking a bit the behavior of non-GUI managers (so that they also store the window title); note that the comment of non-GUIs returning None was clearly wrong.
Closes#29779.
PR summary
PR checklist