Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Use PEP8 style method and function names from pyparsing#29745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ptmcg commentedMar 13, 2025
Note that pyparsing 3.0 requires Python 3.6 or later. |
ptmcg commentedMar 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I also discovered that there are several non-PEP8 attributes on I'll implement the synonyms for |
timhoffm commentedMar 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the hint. I think it's not a problem in practice. Perour dependency policy we are requiring |
At the library level we should provide functional floors to our version pinning (using caps only if weknow it will break us) and leave retro-actively adjusting pins to packagers / integrators. |
705a3a3
to82cf793
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
timhoffm commentedApr 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Do you want to keep commits or should this be squashed? - Either way, you can merge yourself. |
d55bdde
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
ptmcg commentedSep 20, 2025
I'm about to release pyparsing 3.3.0 next month, but the latest 3.10.6 release of matplotlib still emits DeprecationWarnings. I thought this work got merged in - I guess "merged" doesn't necessarily mean "goes out in the next release." How can I coordinate my 3.3.0 release with matplotlib to head off a storm of "I'm getting DeprecationWarnings now!" reports? |
Thanks for the heads-up. We are a bit later than originally planned with the 3.11 release, but should possibly have put the changes in the 3.10.x bugfix releases. I'll do that now, but I'm unsure whether we'll still do a 3.10.7. Eithe way, we need to coordinate, because we indeed don't want the deprecation warnings to show up with users. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…s frompyparsing* Bump minimum pyparsing version* Use PEP8 method names from pyparsing* Add api note* Clean up pyparsing<3 code* Remove unused import* Clean up pyparsing import* Sort imports(cherry picked from commitd55bdde)
ptmcg commentedSep 20, 2025
Will definitely do so. I have a set of matplotlib tests as part of my unit tests, so that I can see this before releasing. |
…0589)* Backport PR#29745: Use PEP8 style method and function names frompyparsing* Bump minimum pyparsing version* Use PEP8 method names from pyparsing* Add api note* Clean up pyparsing<3 code* Remove unused import* Clean up pyparsing import* Sort imports(cherry picked from commitd55bdde)* Remove erroneous pillow bumpCo-authored-by: Thomas A Caswell <tcaswell@gmail.com>* Update pyproject.tomlCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>---------Co-authored-by: David Stansby <dstansby@gmail.com>Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
PR summary
See#29722 for context, this prepares for a pyparsing 3.3.0 release. This requires a bump of the minimum version to 3.0. That was released in 2021, so is easily within our dependency policy of at >= 12 months.
PR checklist