Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Add font feature API to Text#29695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
A difficulty that I've not really handled with mplcairo but warrants at least discussion is what you want to do with subranges. Harfbuzz supports toggling a feature only for some of the characters (seehttps://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string, e.g. The two main alternatives I can think of are either to do nothing, like mplcairo (subranges are interpreted as "repeated over each line"), or to reparse ranges and reinterpret them as "indices over the full string" (after line splitting, matplotlib tweaks the actual ranges than get fed to harfbuzz when shaping each line). |
Also, looking at this again, I wonder how well this will interact with font fallback: it seems not unreasonable that two entries in the font fallback list would want to use different font features (e.g., a latin script and a chinese script likely want very different font features). Perhaps the real question here is whether font fallback should really have been implemented by stashing (references to) multiple fonts in a single FontProperties (though I'm not sure I can immediately design something much better), but the PR here makes the question more salient, I'd say. |
Since we have automatic wrapping ( For settings across font fallback, I guess that is possible to do, but it might require quite a bit of bookkeeping work. |
Uh oh!
There was an error while loading.Please reload this page.
The comments at#29794 (comment) also apply, but because this PR doesn't actually touch the rendering API, I guess it's fine. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Discussed on a developer call we decided to not implement the sub-range application yet. Promoting a tuple of strings to |
Even if we don't explicitly support sub-ranges, we still need to decide what happens if someone writes e.g. |
Since we moved the information from matplotlib/lib/matplotlib/text.py Line 805 inb4cb934
I tried a small change: diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.pyindex 3b0de58814..b255a93c52 100644--- a/lib/matplotlib/text.py+++ b/lib/matplotlib/text.py@@ -800,9 +800,7 @@ class Text(Artist): angle = self.get_rotation() for line, wh, x, y in info:-- mtext = self if len(info) == 1 else None x = x + posx y = y + posy if renderer.flipy():@@ -816,14 +814,19 @@ class Text(Artist): else: textrenderer = renderer- if self.get_usetex():- textrenderer.draw_tex(gc, x, y, clean_line,- self._fontproperties, angle,- mtext=mtext)- else:- textrenderer.draw_text(gc, x, y, clean_line,- self._fontproperties, angle,- ismath=ismath, mtext=mtext)+ xt, yt = self.get_transform().inverted().transform((x, y))+ with cbook._setattr_cm(self, _x=xt, _y=yt, _text=clean_line,+ convert_xunits=lambda x: x,+ convert_yunits=lambda y: y,+ _horizontalalignment='left', _verticalalignment='bottom'):+ if self.get_usetex():+ textrenderer.draw_tex(gc, x, y, clean_line,+ self._fontproperties, angle,+ mtext=self)+ else:+ textrenderer.draw_text(gc, x, y, clean_line,+ self._fontproperties, angle,+ ismath=ismath, mtext=self) gc.restore() renderer.close_group('text') AFAICT, only the PGF backend uses matplotlib/lib/matplotlib/backends/backend_pgf.py Lines 697 to 700 in6db18d5
|
lib/matplotlib/tests/test_text.py Outdated
@image_comparison(baseline_images=['features.png'],remove_text=False,style='mpl20') | ||
deftest_text_features(): | ||
fig=plt.figure(figsize=(5,1.5)) | ||
t=fig.text(0,0.7,'Default: fi ffi fl st',fontsize=32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you pad out the label strings to the same size so that the first letters of the example text line up? Does not matter for the machine to check, but makes it a bit easier for the humans to check the differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I spend so much time looking at monospace fonts I forget not all fonts are monospace 🤦🏻 .
Right-align is exactly what I wanted.
b474c3e
to062b130
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approving but not merging because some image change squashing/interactions with other PRs can be handled by@QuLogic
Font features allow font designers to provide alternate glyphs orshaping within a single font. These features may be accessed via specialtags corresponding to internal tables of glyphs.The mplcairo backend supports font features via an elaborate re-use ofthe font file path [1]. This commit adds the API to make this officiallysupported in the main user API.[1]https://github.com/matplotlib/mplcairo/blob/v0.6.1/README.rst#font-formats-and-features
Rebased without the image change (moved to |
a6ac58f
intomatplotlib:text-overhaulUh oh!
There was an error while loading.Please reload this page.
PR summary
Font features allow font designers to provide alternate glyphs or shaping within a single font. These features may be accessed via special tags corresponding to internal tables of glyphs.
The mplcairo backend supports font features via anelaborate re-use of the font file path. This commit adds the API to make this officially supported in the main user API.
At this time, nothing in Matplotlib itself uses these settings, but they will have an effect with libraqm. I am opening this PR early for review of the API while I work through some issues with the latter. Consequently, the What's New notewill not show the effect of this API, and there are only smoke tests.
PR checklist